Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: Tools/GardeningServer/scripts/ui.js

Issue 416673003: Show non-webkit test failures in the failure stream (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/scripts/ui_unittests.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 16 matching lines...) Expand all
27 27
28 (function () { 28 (function () {
29 29
30 // FIXME: Put this all in a more appropriate place. 30 // FIXME: Put this all in a more appropriate place.
31 31
32 ui.displayNameForBuilder = function(builderName) 32 ui.displayNameForBuilder = function(builderName)
33 { 33 {
34 return builderName.replace(/Webkit /i, ''); 34 return builderName.replace(/Webkit /i, '');
35 } 35 }
36 36
37 ui.urlForFlakinessDashboard = function(opt_testNameList) 37 // FIXME: Take a master name argument as well.
38 ui.urlForFlakinessDashboard = function(testNames, testType)
38 { 39 {
39 var testsParameter = opt_testNameList ? opt_testNameList.join(',') : ''; 40 if (Array.isArray(testNames))
40 return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html# tests=' + encodeURIComponent(testsParameter); 41 testNames = testNames.join(',');
42
43 // FIXME: Remove this once the flakiness dashboard stops having webkit_tests
44 // masquerade as layout-tests.
45 if (testType == 'webkit_tests')
46 testType = 'layout-tests';
47
48 return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html# ' +
49 Object.toQueryString({
50 tests: testNames,
51 testType: testType,
52 });
41 } 53 }
42 54
43 ui.urlForEmbeddedFlakinessDashboard = function(opt_testNameList) 55 ui.urlForEmbeddedFlakinessDashboard = function(testNames, testType)
44 { 56 {
45 return ui.urlForFlakinessDashboard(opt_testNameList) + '&showChrome=false'; 57 return ui.urlForFlakinessDashboard(testNames, testType) + '&showChrome=false ';
46 } 58 }
47 59
48 })(); 60 })();
OLDNEW
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/scripts/ui_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698