gclient DEPS file for auto checking out deps

gclient DEPS file for auto checking out deps

Added a DEPS file so that bot_update and gclient can automatically check
out dependencies (GYP, V8, ICU, and on Windows, Cygwin).

BUG=375773
R=jam@chromium.org, nodir@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/2ee9c3a

[aneeshm, 2014-07-23 20:02:12]

ptal

[nodir, 2014-07-23 20:48:47]

Nit only. Need other's approval for validating the semantics

https://codereview.chromium.org/416663002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/416663002/diff/1/DEPS#newcode3
DEPS:3: "http://gyp.googlecode.com/svn/trunk",
Maybe indent values by 4 spaces?

https://codereview.chromium.org/416663002/diff/1/DEPS#newcode15
DEPS:15: "http://src.chromium.org/svn/trunk/deps/third_party/cygwin@231940",
Here you do it, buy by 2 spaces

[aneeshm, 2014-07-23 23:37:04]

On 2014/07/23 20:48:47, nodir wrote:
> Nit only. Need other's approval for validating the semantics
> 
> https://codereview.chromium.org/416663002/diff/1/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/416663002/diff/1/DEPS#newcode3
> DEPS:3: "http://gyp.googlecode.com/svn/trunk",
> Maybe indent values by 4 spaces?
> 
> https://codereview.chromium.org/416663002/diff/1/DEPS#newcode15
> DEPS:15: "http://src.chromium.org/svn/trunk/deps/third_party/cygwin@231940",
> Here you do it, buy by 2 spaces

You're right. Fixed.

[aneeshm, 2014-07-23 23:37:41]

On 2014/07/23 23:37:04, aneeshm wrote:
> On 2014/07/23 20:48:47, nodir wrote:
> > Nit only. Need other's approval for validating the semantics
> > 
> > https://codereview.chromium.org/416663002/diff/1/DEPS
> > File DEPS (right):
> > 
> > https://codereview.chromium.org/416663002/diff/1/DEPS#newcode3
> > DEPS:3: "http://gyp.googlecode.com/svn/trunk",
> > Maybe indent values by 4 spaces?
> > 
> > https://codereview.chromium.org/416663002/diff/1/DEPS#newcode15
> > DEPS:15: "http://src.chromium.org/svn/trunk/deps/third_party/cygwin@231940",
> > Here you do it, buy by 2 spaces
> 
> You're right. Fixed.

Re-PTAL.

[jam, 2014-07-24 01:28:02]

lgtm, thanks

https://codereview.chromium.org/416663002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/416663002/diff/20001/DEPS#newcode2
DEPS:2: "pdfium/build/gyp":
nit: sorry to nit, but let's do what chrome's src/DEPS does which is 2 space
indents

[agable, 2014-07-24 18:38:06]

On 2014/07/24 01:28:02, jam wrote:
> lgtm, thanks
> 
> https://codereview.chromium.org/416663002/diff/20001/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/416663002/diff/20001/DEPS#newcode2
> DEPS:2: "pdfium/build/gyp":
> nit: sorry to nit, but let's do what chrome's src/DEPS does which is 2 space
> indents

I would consider making this a git-only DEPS file. Point at the git mirrors of
all of these repos (they're all on chromium.googlesource.com). jam@, how would
you feel about that?

[jam, 2014-07-24 20:05:29]

On 2014/07/24 18:38:06, agable wrote:
> On 2014/07/24 01:28:02, jam wrote:
> > lgtm, thanks
> > 
> > https://codereview.chromium.org/416663002/diff/20001/DEPS
> > File DEPS (right):
> > 
> > https://codereview.chromium.org/416663002/diff/20001/DEPS#newcode2
> > DEPS:2: "pdfium/build/gyp":
> > nit: sorry to nit, but let's do what chrome's src/DEPS does which is 2 space
> > indents
> 
> I would consider making this a git-only DEPS file. Point at the git mirrors of
> all of these repos (they're all on http://chromium.googlesource.com). jam@,
how would
> you feel about that?

I don't care either way, whatever you prefer.

[aneeshm, 2014-07-25 21:31:03]

On 2014/07/24 20:05:29, jam wrote:
> On 2014/07/24 18:38:06, agable wrote:
> > On 2014/07/24 01:28:02, jam wrote:
> > > lgtm, thanks
> > > 
> > > https://codereview.chromium.org/416663002/diff/20001/DEPS
> > > File DEPS (right):
> > > 
> > > https://codereview.chromium.org/416663002/diff/20001/DEPS#newcode2
> > > DEPS:2: "pdfium/build/gyp":
> > > nit: sorry to nit, but let's do what chrome's src/DEPS does which is 2
space
> > > indents
> > 
> > I would consider making this a git-only DEPS file. Point at the git mirrors
of
> > all of these repos (they're all on http://chromium.googlesource.com). jam@,
> how would
> > you feel about that?
> 
> I don't care either way, whatever you prefer.

I think Aaron is right, and that it's better to use git wherever possible from
now on.

Fixed.

PTAL.

[jam, 2014-07-28 06:46:28]

lgtm, can you please use 2 space indents to match chromium though?

[jam, 2014-07-28 06:47:43]

please visit https://pdfium-review.googlesource.com/ with your chromium account
andIM me, then I can add you as a committer

[aneeshm, 2014-07-28 19:48:30]

Just fixed it to two spaces.

PTAL.

[agable, 2014-07-30 17:05:56]

https://codereview.chromium.org/416663002/diff/60001/DEPS
File DEPS (right):

https://codereview.chromium.org/416663002/diff/60001/DEPS#newcode3
DEPS:3: "https://chromium.googlesource.com/external/gyp/",
no trailing slash

https://codereview.chromium.org/416663002/diff/60001/DEPS#newcode6
DEPS:6: "https://chromium.googlesource.com/external/v8/",
no trailing slash

https://codereview.chromium.org/416663002/diff/60001/DEPS#newcode15
DEPS:15:
"https://chromium.googlesource.com/chromium/deps/icu46@fffc215567216e09f56578b254a56668f1c89add",
you accidentally replaced 'third_party/cygwin' with 'icu' here. Please fix and
double-check the git hash.

[aneeshm, 2014-07-30 19:52:06]

On 2014/07/30 17:05:56, agable wrote:
> https://codereview.chromium.org/416663002/diff/60001/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/416663002/diff/60001/DEPS#newcode3
> DEPS:3: "https://chromium.googlesource.com/external/gyp/",
> no trailing slash
> 
> https://codereview.chromium.org/416663002/diff/60001/DEPS#newcode6
> DEPS:6: "https://chromium.googlesource.com/external/v8/",
> no trailing slash
> 
> https://codereview.chromium.org/416663002/diff/60001/DEPS#newcode15
> DEPS:15:
>
"https://chromium.googlesource.com/chromium/deps/icu46@fffc215567216e09f56578b254a56668f1c89add",
> you accidentally replaced 'third_party/cygwin' with 'icu' here. Please fix and
> double-check the git hash.

Fixed.

PTAL.

[jam, 2014-07-30 20:23:35]

slgtm

[aneeshm, 2014-07-30 21:12:48]

On 2014/07/30 20:23:35, jam wrote:
> slgtm

What's that?

[aneeshm, 2014-08-05 20:15:42]

The CQ bit was checked by aneeshm@chromium.org

[commit-bot: I haz the power, 2014-08-05 20:18:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 20:18:45]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[nodir, 2014-08-06 00:08:15]

On 2014/07/30 21:12:48, aneeshm wrote:
> On 2014/07/30 20:23:35, jam wrote:
> > slgtm
> 
> What's that?

https://wtf/slgtm

[nodir, 2014-08-06 00:08:46]

On 2014/08/06 00:08:15, nodir wrote:
> On 2014/07/30 21:12:48, aneeshm wrote:
> > On 2014/07/30 20:23:35, jam wrote:
> > > slgtm
> > 
> > What's that?
> 
> https://wtf/slgtm

http://wtf/slgtm

[aneeshm, 2014-08-07 01:11:33]

Committed patchset #5 manually as 2ee9c3a (presubmit successful).