moved commonly used private functions to it's own utility file.

Placed private functions in it's own commonly used utils file.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64315

[dyu1, 2010-10-28 19:50:03]

added WaitUntil function to fix bug 60953 for Find_In_Page.py

[Nirnimesh, 2010-10-28 20:26:57]

Please enable the test in PYAUTO_TESTS

http://codereview.chromium.org/4166006/diff/1/2
File chrome/test/functional/find_in_page.py (right):

http://codereview.chromium.org/4166006/diff/1/2#newcode83
chrome/test/functional/find_in_page.py:83: # wait until page is loaded
add something like:
the contents in the history page load asynchronously after the tab is loaded.
Try it a few times.

[dyu1, 2010-10-28 21:10:43]

Made the suggested changes and deleted the line in PYAUTO_TESTS where the test
was disabled.

http://codereview.chromium.org/4166006/diff/1/2
File chrome/test/functional/find_in_page.py (right):

http://codereview.chromium.org/4166006/diff/1/2#newcode83
chrome/test/functional/find_in_page.py:83: # wait until page is loaded
On 2010/10/28 20:26:57, Nirnimesh wrote:
> add something like:
> the contents in the history page load asynchronously after the tab is loaded.
> Try it a few times.

Done.

[Nirnimesh, 2010-10-28 21:20:02]

http://codereview.chromium.org/4166006/diff/5001/6002
File chrome/test/functional/find_in_page.py (right):

http://codereview.chromium.org/4166006/diff/5001/6002#newcode91
chrome/test/functional/find_in_page.py:91: # wait for downloads page to load
please repeat the previous comment for downloads page here

[dyu1, 2010-10-28 21:23:59]

done

http://codereview.chromium.org/4166006/diff/5001/6002
File chrome/test/functional/find_in_page.py (right):

http://codereview.chromium.org/4166006/diff/5001/6002#newcode91
chrome/test/functional/find_in_page.py:91: # wait for downloads page to load
On 2010/10/28 21:20:03, Nirnimesh wrote:
> please repeat the previous comment for downloads page here

Done.

[Nirnimesh, 2010-10-28 21:26:47]

LGTM. I'll commit this.

[dyu1, 2010-10-29 00:51:48]

DownloadTestFile and RemoveTestFile functions are used in other tests as well,
so moved them into a test utils file where more commonly used functions could be
added.

[Nirnimesh, 2010-10-29 00:54:47]

On 2010/10/29 00:51:48, dyu1 wrote:
> DownloadTestFile and RemoveTestFile functions are used in other tests as well,
> so moved them into a test utils file where more commonly used functions could
be
> added.

I'm afraid I had already committed. Please create a new CL for further changes.

[Paweł Hajdan Jr., 2010-10-29 10:25:35]

No, please, noooooooooo!

We can wait for the DOMUI pages to fully load, and we should. I mean that
instead of using WaitUntil (which internally is a sleep'n'loop), we should wait
properly on the browser side.

[Nirnimesh, 2010-10-29 15:42:04]

On 2010/10/29 10:25:35, Paweł Hajdan Jr. wrote:
> No, please, noooooooooo!
> 
> We can wait for the DOMUI pages to fully load, and we should.

How?
To be clear, the page commits but the content loads asynchronously, I think.

[Paweł Hajdan Jr., 2010-10-29 15:47:43]

On Fri, Oct 29, 2010 at 17:42, <nirnimesh@chromium.org> wrote:

> On 2010/10/29 10:25:35, Paweł Hajdan Jr. wrote:
>
>> No, please, noooooooooo!
>>
>
>  We can wait for the DOMUI pages to fully load, and we should.
>>
>
> How?
> To be clear, the page commits but the content loads asynchronously, I
> think.


Yes, but the code should be quite clean, so we can wait for the asynchronous
load as well. We can even do it transparently, similar to how we wait for
browser commands to complete. We can recognize a DOMUI page and instead of
waiting for just the page load to finish, also wait for the "full load".