Issue 416543003: Move GCTracer to separate files.

Issue 416543003: Move GCTracer to separate files. (Closed)

Created:
6 years, 5 months ago by ernstm

Modified:
6 years, 5 months ago

Reviewers:
Hannes Payer (out of office), Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Move GCTracer to separate files. - No functional changes. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22600

Patch Set 2 : Updates #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+524 lines, -501 lines)			Patch
M	BUILD.gn	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	src/gc-tracer.h	View	1	1 chunk	+247 lines, -0 lines	0 comments	Download
A	src/gc-tracer.cc	View	1	1 chunk	+272 lines, -0 lines	0 comments	Download
M	src/heap.h	View	1	2 chunks	+1 line, -238 lines	0 comments	Download
M	src/heap.cc	View	1	2 chunks	+0 lines, -263 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM, just nits, BUILD.gn update https://codereview.chromium.org/416543003/diff/1/src/gc-tracer.h File src/gc-tracer.h (right): https://codereview.chromium.org/416543003/diff/1/src/gc-tracer.h#newcode11 src/gc-tracer.h:11: // TODO(ernstm): Move into ...

6 years, 5 months ago (2014-07-24 09:03:33 UTC) #3

ernstm

- Rebased after revert and re-land of precursor CL. - BUILD.gn updated. https://codereview.chromium.org/416543003/diff/1/src/gc-tracer.h File src/gc-tracer.h ...

6 years, 5 months ago (2014-07-24 11:49:49 UTC) #4

ernstm

6 years, 5 months ago (2014-07-24 13:06:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r22600 (presubmit successful).

Expand Messages | Collapse Messages