Hide the Paste popup when input is received from IME.

Hide the Paste popup when input is received from IME.

Paste popup should be hidden from the corresponding
input box whenever there is a change in focus.This
change takes care of hiding the paste popup when
focus is changing from edit field to URL bar.

BUG=396620
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285047

[Cyan, 2014-07-23 13:55:21]

@jdduke
PTAL

[jdduke (slow), 2014-07-23 14:35:14]

https://codereview.chromium.org/416493003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/416493003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1687:
if (getPastePopup().isShowing())
We shouldn't instantiate a new PastePopup (done by getPastePopup()) just to
check if it's showing.  Please use the existing |hidePastePopup()| method, and
put the method under the if (!gainFocus) branch.

Hmm, actually, do we get a SelectionEvent after we lose focus? Could you check
if there are any events forwarded to onSelectionEvent() at some point in this
sequence?

[Cyan, 2014-07-23 15:41:52]

@jdduke
PTAL

https://codereview.chromium.org/416493003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/416493003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1687:
if (getPastePopup().isShowing())
On 2014/07/23 14:35:14, jdduke wrote:
> We shouldn't instantiate a new PastePopup (done by getPastePopup()) just to
> check if it's showing.  Please use the existing |hidePastePopup()| method, and
> put the method under the if (!gainFocus) branch.
> 
> Hmm, actually, do we get a SelectionEvent after we lose focus? Could you check
> if there are any events forwarded to onSelectionEvent() at some point in this
> sequence?
@jdduke:
We are not getting any SelectionEvent after we lose focus.In fact no event is
being forwarded to SelectionEvent in this sequence.I'm modifying the patch the
way you suggested. Will upload the new patch in sometime.

[Cyan, 2014-07-23 15:48:19]

On 2014/07/23 15:41:52, sayan.nayak wrote:
> @jdduke
> PTAL
> 
>
https://codereview.chromium.org/416493003/diff/1/content/public/android/java/...
> File
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
> (right):
> 
>
https://codereview.chromium.org/416493003/diff/1/content/public/android/java/...
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1687:
> if (getPastePopup().isShowing())
> On 2014/07/23 14:35:14, jdduke wrote:
> > We shouldn't instantiate a new PastePopup (done by getPastePopup()) just to
> > check if it's showing.  Please use the existing |hidePastePopup()| method,
and
> > put the method under the if (!gainFocus) branch.
> > 
> > Hmm, actually, do we get a SelectionEvent after we lose focus? Could you
check
> > if there are any events forwarded to onSelectionEvent() at some point in
this
> > sequence?
> @jdduke:
> We are not getting any SelectionEvent after we lose focus.In fact no event is
> being forwarded to SelectionEvent in this sequence.I'm modifying the patch the
> way you suggested. Will upload the new patch in sometime.

@jdduke:
uploaded new patch as suggested. PTAL

[Cyan, 2014-07-23 15:54:56]

On 2014/07/23 15:48:19, sayan.nayak wrote:
> On 2014/07/23 15:41:52, sayan.nayak wrote:
> > @jdduke
> > PTAL
> > 
> >
>
https://codereview.chromium.org/416493003/diff/1/content/public/android/java/...
> > File
> >
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/416493003/diff/1/content/public/android/java/...
> >
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1687:
> > if (getPastePopup().isShowing())
> > On 2014/07/23 14:35:14, jdduke wrote:
> > > We shouldn't instantiate a new PastePopup (done by getPastePopup()) just
to
> > > check if it's showing.  Please use the existing |hidePastePopup()| method,
> and
> > > put the method under the if (!gainFocus) branch.
> > > 
> > > Hmm, actually, do we get a SelectionEvent after we lose focus? Could you
> check
> > > if there are any events forwarded to onSelectionEvent() at some point in
> this
> > > sequence?
> > @jdduke:
> > We are not getting any SelectionEvent after we lose focus.In fact no event
is
> > being forwarded to SelectionEvent in this sequence.I'm modifying the patch
the
> > way you suggested. Will upload the new patch in sometime.
> 
> @jdduke:
> uploaded new patch as suggested. PTAL

removed the unnecessary branch condition in 2nd patch PTAL

[jdduke (slow), 2014-07-23 15:57:42]

lgtm

[Cyan, 2014-07-23 15:58:16]

The CQ bit was checked by sayan.nayak@samsung.com

[commit-bot: I haz the power, 2014-07-23 15:58:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/416493003/20001

[commit-bot: I haz the power, 2014-07-23 19:30:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-23 21:34:13]

Change committed as 285047