Fixed Gaia reloading.

Fixed Gaia reloading.

Previously in the case of auth frame loading timeout auth frame was not reloaded, since we expected that frame will send an error to SigninScreenHandler. Current implementation explicitly reloads web frame when timeout happens.

BUG=394970
TEST=manual
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284976

[Nikita (slow), 2014-07-23 13:34:16]

lgtm

https://codereview.chromium.org/416493002/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/416493002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:675:
ReloadGaia(false);
Comment says "Forces a reload for GAIA".
Considering IsGaiaHiddenByError() condition it seems that force_reload should be
true in this case.

[ygorshenin1, 2014-07-23 13:38:48]

https://codereview.chromium.org/416493002/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/416493002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:675:
ReloadGaia(false);
Not sure, because we'll try to reload already reloading Gaia.

On 2014/07/23 13:34:16, Nikita Kostylev wrote:
> Comment says "Forces a reload for GAIA".
> Considering IsGaiaHiddenByError() condition it seems that force_reload should
be
> true in this case.

[Nikita (slow), 2014-07-23 13:55:41]

https://codereview.chromium.org/416493002/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/416493002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:675:
ReloadGaia(false);
On 2014/07/23 13:38:48, ygorshenin1 wrote:
> Not sure, because we'll try to reload already reloading Gaia.
> 
> On 2014/07/23 13:34:16, Nikita Kostylev wrote:
> > Comment says "Forces a reload for GAIA".
> > Considering IsGaiaHiddenByError() condition it seems that force_reload
should
> be
> > true in this case.
> 

As far as I understand in case of IsGaiaHiddenByError()
gaia loading might be stopped. If we don't force_reload it here what if it never
reloads again i.e. what guarantees that reload would actually finish.

[ygorshenin1, 2014-07-23 13:59:12]

https://codereview.chromium.org/416493002/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/416493002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:675:
ReloadGaia(false);
ReloadGaia(true) means "reload gaia in any case, even if it's already loading".
ReloadGaia(false) means "reload gaia if it's not loading right now".
So call to ReloadGaia() in any case establishes that gaia is reloading.

On 2014/07/23 13:55:41, Nikita Kostylev wrote:
> On 2014/07/23 13:38:48, ygorshenin1 wrote:
> > Not sure, because we'll try to reload already reloading Gaia.
> > 
> > On 2014/07/23 13:34:16, Nikita Kostylev wrote:
> > > Comment says "Forces a reload for GAIA".
> > > Considering IsGaiaHiddenByError() condition it seems that force_reload
> should
> > be
> > > true in this case.
> > 
> 
> As far as I understand in case of IsGaiaHiddenByError()
> gaia loading might be stopped. If we don't force_reload it here what if it
never
> reloads again i.e. what guarantees that reload would actually finish.

[ygorshenin1, 2014-07-23 14:26:51]

The CQ bit was checked by ygorshenin@chromium.org

[commit-bot: I haz the power, 2014-07-23 14:27:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/416493002/1

[commit-bot: I haz the power, 2014-07-23 15:50:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-23 16:09:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 16:09:41]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[ygorshenin1, 2014-07-23 17:10:08]

The CQ bit was checked by ygorshenin@chromium.org

[commit-bot: I haz the power, 2014-07-23 17:11:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/416493002/1

[ygorshenin1, 2014-07-23 17:14:38]

The CQ bit was unchecked by ygorshenin@chromium.org

[ygorshenin1, 2014-07-23 17:14:50]

The CQ bit was checked by ygorshenin@chromium.org

[commit-bot: I haz the power, 2014-07-23 17:17:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/416493002/1

[commit-bot: I haz the power, 2014-07-23 17:19:47]

Change committed as 284976