Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: content/child/webthread_impl.h

Issue 416453002: Move the shared timer to be dynamically allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/webthread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webthread_impl.h
diff --git a/content/child/webthread_impl.h b/content/child/webthread_impl.h
index 476445284c8938972c4e1fc0558262737a8abb1f..3b5852c032144c1547bcf1deee38264be0454480 100644
--- a/content/child/webthread_impl.h
+++ b/content/child/webthread_impl.h
@@ -64,7 +64,9 @@ class CONTENT_EXPORT WebThreadImpl : public WebThreadBase {
if (shared_timer_function_)
shared_timer_function_();
}
- base::OneShotTimer<WebThreadImpl> shared_timer_;
+ // The shared timer is a scoped_ptr, so it can be deleted on the same
+ // thread that created it.
+ scoped_ptr<base::OneShotTimer<WebThreadImpl> > shared_timer_;
SharedTimerFunction shared_timer_function_;
scoped_ptr<base::Thread> thread_;
« no previous file with comments | « no previous file | content/child/webthread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698