Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 416453002: Move the shared timer to be dynamically allocated. (Closed)

Created:
6 years, 5 months ago by nasko
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Move the shared timer to be dynamically allocated. The shared timer must be deleted on the same thread that it was executing on. When the WebThread is being destroyed, it is done from a different thread, so the shared timer must be deleted prior to that. This gives an API for the thread cleanup code to do so. BUG=301515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M content/child/webthread_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/child/webthread_impl.cc View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nasko
Hey Jochen, Can you review this CL for me? The crashes I was hitting were ...
6 years, 5 months ago (2014-07-23 09:42:27 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-23 09:47:25 UTC) #2
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 5 months ago (2014-07-23 09:51:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/416453002/1
6 years, 5 months ago (2014-07-23 09:52:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 11:33:50 UTC) #5
nasko
The CQ bit was unchecked by nasko@chromium.org
6 years, 5 months ago (2014-07-23 14:26:09 UTC) #6
nasko
6 years, 5 months ago (2014-07-24 07:18:23 UTC) #7
This landed as r284920, the dcommit tool gave out an error and didn't update
this issue. 

http://src.chromium.org/viewvc/chrome?revision=284920

Powered by Google App Engine
This is Rietveld 408576698