Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 416433002: Add basic test cases for the end to end testing of print preview. (Closed)

Created:
6 years, 5 months ago by ivandavid
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang, Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

There are a 8 basic test cases of varying types including text only html files, some html files with forms, an image, and a color-gradient. BUG=388517 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285527

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added html to the DOCTYPE comment and removed the 'tests' directory. #

Patch Set 3 : Replaced old image. #

Messages

Total messages: 14 (0 generated)
ivandavid
6 years, 5 months ago (2014-07-23 03:28:22 UTC) #1
Lei Zhang
How do you feel about the ones with text? We talked about how text rendering ...
6 years, 5 months ago (2014-07-23 17:23:54 UTC) #2
Lei Zhang
Why do the tests in layout_tests/tests? Do you need the extra "tests" sub-directory? As with ...
6 years, 5 months ago (2014-07-23 17:29:20 UTC) #3
ivandavid
I removed the tests directory. I know that we said no images, this one is ...
6 years, 5 months ago (2014-07-23 18:53:01 UTC) #4
ivandavid
Also, I feel that some text is necessary, even though it is probably the most ...
6 years, 5 months ago (2014-07-23 18:54:34 UTC) #5
Lei Zhang
On 2014/07/23 18:53:01, ivandavid wrote: > I removed the tests directory. I know that we ...
6 years, 5 months ago (2014-07-23 19:21:48 UTC) #6
ivandavid
I replaced the old image.
6 years, 5 months ago (2014-07-24 22:28:20 UTC) #7
Lei Zhang
Did you accidentally change print_preview_pdf_generated_browsertest.cc in this CL?
6 years, 5 months ago (2014-07-24 22:31:47 UTC) #8
ivandavid
On 2014/07/24 22:31:47, Lei Zhang wrote: > Did you accidentally change print_preview_pdf_generated_browsertest.cc in this > ...
6 years, 5 months ago (2014-07-24 22:38:46 UTC) #9
Lei Zhang
lgtm
6 years, 5 months ago (2014-07-24 22:58:22 UTC) #10
ivandavid
The CQ bit was checked by ivandavid@chromium.org
6 years, 5 months ago (2014-07-24 22:58:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivandavid@chromium.org/416433002/100001
6 years, 5 months ago (2014-07-24 23:00:27 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 06:06:52 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 08:17:37 UTC) #14
Message was sent while issue was closed.
Change committed as 285527

Powered by Google App Engine
This is Rietveld 408576698