Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 416403013: Remove Element.scrollByLines() and Element.scrollByPages() (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Remove Element.scrollByLines() and Element.scrollByPages() Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KYJoVzmi_tw/OsTpm27Ty9YJ BUG=398356 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -79 lines) Patch
M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/scroll-event-does-not-bubble.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/layers/scroll-overflow-no-layer.html View 1 chunk +3 lines, -4 lines 0 comments Download
A + LayoutTests/fast/layers/scroll-overflow-no-layer-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/fast/layers/scrollByLines-overflow-no-layer.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/layers/scrollByLines-overflow-no-layer-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/Element.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-07-29 09:16:36 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-29 11:41:20 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-29 11:45:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/416403013/1
6 years, 4 months ago (2014-07-29 11:45:56 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 12:27:00 UTC) #5
Message was sent while issue was closed.
Change committed as 179134

Powered by Google App Engine
This is Rietveld 408576698