Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Unified Diff: src/store-buffer.cc

Issue 416403011: Fix bogus assert in HeapIterator. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/spaces.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/store-buffer.cc
diff --git a/src/store-buffer.cc b/src/store-buffer.cc
index dbd9cc7415e04b47bf57f3aedf8143ff3dfb9930..34835f0ee03844a1df2ab187dc078cfabb117b3c 100644
--- a/src/store-buffer.cc
+++ b/src/store-buffer.cc
@@ -505,9 +505,9 @@ void StoreBuffer::IteratePointersToNewSpace(ObjectSlotCallback slot_callback,
}
}
} else {
- if (page->parallel_sweeping() > MemoryChunk::SWEEPING_FINALIZE) {
+ if (!page->SweepingCompleted()) {
heap_->mark_compact_collector()->SweepInParallel(page, owner);
- if (page->parallel_sweeping() > MemoryChunk::SWEEPING_FINALIZE) {
+ if (!page->SweepingCompleted()) {
// We were not able to sweep that page, i.e., a concurrent
// sweeper thread currently owns this page.
// TODO(hpayer): This may introduce a huge pause here. We
« no previous file with comments | « src/spaces.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698