Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: src/spaces.cc

Issue 416403011: Fix bogus assert in HeapIterator. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/spaces.h ('k') | src/store-buffer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/base/platform/platform.h" 7 #include "src/base/platform/platform.h"
8 #include "src/full-codegen.h" 8 #include "src/full-codegen.h"
9 #include "src/macro-assembler.h" 9 #include "src/macro-assembler.h"
10 #include "src/mark-compact.h" 10 #include "src/mark-compact.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 owner == page->heap()->old_data_space() || 51 owner == page->heap()->old_data_space() ||
52 owner == page->heap()->map_space() || 52 owner == page->heap()->map_space() ||
53 owner == page->heap()->cell_space() || 53 owner == page->heap()->cell_space() ||
54 owner == page->heap()->property_cell_space() || 54 owner == page->heap()->property_cell_space() ||
55 owner == page->heap()->code_space()); 55 owner == page->heap()->code_space());
56 Initialize(reinterpret_cast<PagedSpace*>(owner), 56 Initialize(reinterpret_cast<PagedSpace*>(owner),
57 page->area_start(), 57 page->area_start(),
58 page->area_end(), 58 page->area_end(),
59 kOnePageOnly, 59 kOnePageOnly,
60 size_func); 60 size_func);
61 ASSERT(page->WasSweptPrecisely()); 61 ASSERT(page->WasSweptPrecisely() || page->SweepingCompleted());
62 } 62 }
63 63
64 64
65 void HeapObjectIterator::Initialize(PagedSpace* space, 65 void HeapObjectIterator::Initialize(PagedSpace* space,
66 Address cur, Address end, 66 Address cur, Address end,
67 HeapObjectIterator::PageMode mode, 67 HeapObjectIterator::PageMode mode,
68 HeapObjectCallback size_f) { 68 HeapObjectCallback size_f) {
69 // Check that we actually can iterate this space. 69 // Check that we actually can iterate this space.
70 ASSERT(space->swept_precisely()); 70 ASSERT(space->swept_precisely());
71 71
(...skipping 3080 matching lines...) Expand 10 before | Expand all | Expand 10 after
3152 object->ShortPrint(); 3152 object->ShortPrint();
3153 PrintF("\n"); 3153 PrintF("\n");
3154 } 3154 }
3155 printf(" --------------------------------------\n"); 3155 printf(" --------------------------------------\n");
3156 printf(" Marked: %x, LiveCount: %x\n", mark_size, LiveBytes()); 3156 printf(" Marked: %x, LiveCount: %x\n", mark_size, LiveBytes());
3157 } 3157 }
3158 3158
3159 #endif // DEBUG 3159 #endif // DEBUG
3160 3160
3161 } } // namespace v8::internal 3161 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/spaces.h ('k') | src/store-buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698