Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 416383004: Attempt to fix some -Woverloaded-virtual warnings. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Attempt to fix some -Woverloaded-virtual warnings. There are many warnings that look like: error: 'CPWL_RadioButton::OnChar' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual FX_BOOL OnChar(FX_WORD nChar); ^ note: hidden overloaded virtual function 'CPWL_Wnd::OnChar' declared here: different number of parameters (2 vs 1) virtual FX_BOOL OnChar(FX_WORD nChar, FX_DWORD nFlag); ^ It looks like someone added the nFlag parameter to the methods in CPWL_Wnd at some point and missed to update all overloads This patch attempts to fix this: It adds the parameter to all methods that look like they're trying to overload the base class method, and renames the method in one case where it fairly clearly looks like that it's not supposed to be an overload. BUG=pdfium:29 R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/f1d18bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M fpdfsdk/include/pdfwindow/PWL_ComboBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_SpecialButton.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_IconList.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
Please take a very careful look – this likely changes behavior, but since I'm not ...
6 years, 4 months ago (2014-07-30 01:22:52 UTC) #1
Bo Xu
On 2014/07/30 01:22:52, Nico (away) wrote: > Please take a very careful look – this likely ...
6 years, 4 months ago (2014-07-30 21:14:58 UTC) #2
Nico
6 years, 4 months ago (2014-07-30 21:17:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rf1d18bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698