Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: content/browser/renderer_host/input/gesture_text_selector_unittest.cc

Issue 416383003: Show handles even when dragging from outside selectable region (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moved TODO Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/input/gesture_text_selector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/input/gesture_text_selector_unittest.cc
diff --git a/content/browser/renderer_host/input/gesture_text_selector_unittest.cc b/content/browser/renderer_host/input/gesture_text_selector_unittest.cc
index 53dca20f57e88cf1d049e28ff02e7adf8f928882..cf1e3b93d4e13c8ad31e9a48afe33694c5603711 100644
--- a/content/browser/renderer_host/input/gesture_text_selector_unittest.cc
+++ b/content/browser/renderer_host/input/gesture_text_selector_unittest.cc
@@ -142,8 +142,7 @@ TEST_F(GestureTextSelectorTest, PenDragging) {
GestureEventDetails(ui::ET_GESTURE_SCROLL_BEGIN, 0, 0), 0, event_time,
x1, y1, x1, y1, 1, gfx::RectF(0, 0, 0, 0));
EXPECT_TRUE(selector_->OnGestureEvent(scroll_begin));
- EXPECT_EQ(2u, event_log_.size()); // Unselect, Show
- EXPECT_STREQ("Show", event_log_.back().c_str());
+ EXPECT_EQ(1u, event_log_.size()); // Unselect
// 5. ET_GESTURE_SCROLL_UPDATE
event_time += base::TimeDelta::FromMilliseconds(10);
@@ -215,7 +214,7 @@ TEST_F(GestureTextSelectorTest, TapToSelectWord) {
GestureEventDetails(ui::ET_GESTURE_TAP, 0, 0), 0, event_time,
x1, y1, x1, y1, 1, gfx::RectF(0, 0, 0, 0));
EXPECT_TRUE(selector_->OnGestureEvent(tap));
- EXPECT_EQ(1u, event_log_.size()); // Unselect, Show
+ EXPECT_EQ(1u, event_log_.size()); // LongPress
EXPECT_STREQ("LongPress", event_log_.back().c_str());
}
« no previous file with comments | « content/browser/renderer_host/input/gesture_text_selector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698