Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 416373002: Cleanup return values in chrome/browser/ui/passwords (Closed)

Created:
6 years, 5 months ago by lucinka.brozkova
Modified:
6 years, 5 months ago
Reviewers:
Mike West
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup return values in chrome/browser/ui/passwords This CL turns const by value return values into const by ref. Replacing const value by a const ref when a member variable is returned is safe, because the member variable will live at least as long as the temporary object returned now. It can also be more efficient, because returning a ref can spare copying. BUG=393155 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/passwords/manage_passwords_ui_controller.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
lucinka.brozkova
Hi Mike, Could you please do an OWNERS review? Thank you. Lucie
6 years, 5 months ago (2014-07-25 10:47:56 UTC) #1
Mike West
On 2014/07/25 10:47:56, lucinka.brozkova wrote: > Hi Mike, > > Could you please do an ...
6 years, 5 months ago (2014-07-25 10:50:12 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-25 10:50:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lucinka.brozkova@gmail.com/416373002/1
6 years, 5 months ago (2014-07-25 10:51:09 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 14:53:44 UTC) #5
Message was sent while issue was closed.
Change committed as 285588

Powered by Google App Engine
This is Rietveld 408576698