Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 416363002: DevTools: Fix Crash Report - v8::Value::IsInt32. (Closed)

Created:
6 years, 5 months ago by aandrey
Modified:
6 years, 4 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix Crash Report - v8::Value::IsInt32. BUG=397440 R=yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179116

Patch Set 1 #

Total comments: 2

Patch Set 2 : enter debugger context #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M Source/core/inspector/JavaScriptCallFrame.cpp View 1 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
aandrey
6 years, 5 months ago (2014-07-25 09:55:12 UTC) #1
aandrey
https://codereview.chromium.org/416363002/diff/1/Source/core/inspector/JavaScriptCallFrame.cpp File Source/core/inspector/JavaScriptCallFrame.cpp (right): https://codereview.chromium.org/416363002/diff/1/Source/core/inspector/JavaScriptCallFrame.cpp#newcode72 Source/core/inspector/JavaScriptCallFrame.cpp:72: if (result.IsEmpty() || !result->IsInt32()) maybe we should add a ...
6 years, 5 months ago (2014-07-25 10:00:52 UTC) #2
aandrey
https://codereview.chromium.org/416363002/diff/1/Source/core/inspector/JavaScriptCallFrame.cpp File Source/core/inspector/JavaScriptCallFrame.cpp (right): https://codereview.chromium.org/416363002/diff/1/Source/core/inspector/JavaScriptCallFrame.cpp#newcode72 Source/core/inspector/JavaScriptCallFrame.cpp:72: if (result.IsEmpty() || !result->IsInt32()) On 2014/07/25 10:00:51, aandrey wrote: ...
6 years, 5 months ago (2014-07-25 10:11:52 UTC) #3
yurys
lgtm
6 years, 4 months ago (2014-07-29 08:18:08 UTC) #4
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-07-29 08:18:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/416363002/20001
6 years, 4 months ago (2014-07-29 08:18:48 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-29 09:27:11 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 09:51:45 UTC) #8
Message was sent while issue was closed. 
Change committed as 179116

Powered by Google App Engine
This is Rietveld 408576698