Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 416343003: Do not handle ui::ET_GESTURE_END events in CustomButton (Closed)

Created:
6 years, 5 months ago by tdanderson
Modified:
6 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Do not handle ui::ET_GESTURE_END events in CustomButton We plan on no longer dispatching GESTURE_END events to views (crbug.com/397564), so do not handle this event type in CustomButton::OnGestureEvent(). This event is currently used to start a fade-out animation on a TAP gesture, but we can accomplish the same goal by starting this animation when receiving the TAP gesture itself. BUG=397579 TEST=MenuButtonTest.ActivateNonDropDownOnGestureTap

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M ui/views/controls/button/custom_button.cc View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tdanderson
Sadrul, can you please take a look? This preserves the existing visual behaviour.
6 years, 5 months ago (2014-07-25 18:50:54 UTC) #1
sadrul
lgtm
6 years, 5 months ago (2014-07-25 20:39:41 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-25 20:43:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/416343003/1
6 years, 5 months ago (2014-07-25 20:45:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 21:49:14 UTC) #5
tdanderson
6 years, 5 months ago (2014-07-25 22:16:52 UTC) #6
The CQ bit was unchecked by tdanderson@chromium.org

Powered by Google App Engine
This is Rietveld 408576698