media/filters/decrypting_audio_decoder.h - Issue 416333011: Allow setContentDecryptionModule() to get called when setting is done.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/decrypting_audio_decoder.h

Issue 416333011: Allow setContentDecryptionModule() to get called when setting is done. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: const & Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/filters/audio_decoder_selector_unittest.cc ('K') | « media/filters/audio_decoder_selector_unittest.cc ('k') | media/filters/decrypting_audio_decoder.cc » ('j') | media/filters/decrypting_audio_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/filters/decrypting_audio_decoder.h

diff --git a/media/filters/decrypting_audio_decoder.h b/media/filters/decrypting_audio_decoder.h

index 70cbc5632268c13130e6e6231bc6901a43b80f69..778ee7af595684f22135d5d48ed3b773a7cc174c 100644

--- a/media/filters/decrypting_audio_decoder.h

+++ b/media/filters/decrypting_audio_decoder.h

@@ -66,8 +66,9 @@ class MEDIA_EXPORT DecryptingAudioDecoder : public AudioDecoder {

kError

};

- // Callback for DecryptorHost::RequestDecryptor().

- void SetDecryptor(Decryptor* decryptor);

+ // Callback for DecryptorHost::RequestDecryptor(). |done_cb| is called when

+ // complete.

ddorwin 2014/07/30 22:35:46 ditto

+ void SetDecryptor(Decryptor* decryptor, const base::Closure& done_cb);

ddorwin 2014/07/30 22:35:46 nit: That might also lead to a better name for |do

jrummell 2014/08/01 22:09:42 Acknowledged.

// Initializes the audio decoder on the |decryptor_| with |config_|.

void InitializeDecoder();