trunk/src/chrome/common/variations/experiment_labels_unittest.cc - Issue 416333008: Revert 285657 "Move variations component code to variations name..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/chrome/common/variations/experiment_labels_unittest.cc

Issue 416333008: Revert 285657 "Move variations component code to variations name..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/src/chrome/common/variations/experiment_labels.cc ('k') | trunk/src/chrome/common/variations/uniformity_field_trials.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/src/chrome/common/variations/experiment_labels_unittest.cc

===================================================================

--- trunk/src/chrome/common/variations/experiment_labels_unittest.cc (revision 285674)

+++ trunk/src/chrome/common/variations/experiment_labels_unittest.cc (working copy)

@@ -18,10 +18,10 @@

namespace chrome_variations {

TEST(ExperimentLabelsTest, BuildGoogleUpdateExperimentLabel) {

- const variations::VariationID TEST_VALUE_A = 3300200;

- const variations::VariationID TEST_VALUE_B = 3300201;

- const variations::VariationID TEST_VALUE_C = 3300202;

- const variations::VariationID TEST_VALUE_D = 3300203;

+ const VariationID TEST_VALUE_A = 3300200;

+ const VariationID TEST_VALUE_B = 3300201;

+ const VariationID TEST_VALUE_C = 3300202;

+ const VariationID TEST_VALUE_D = 3300203;

struct {

const char* active_group_pairs;

@@ -45,14 +45,14 @@

};

// Register a few VariationIDs.

- AssociateGoogleVariationID(variations::GOOGLE_UPDATE_SERVICE, "FieldTrialA",

- "Default", TEST_VALUE_A);

- AssociateGoogleVariationID(variations::GOOGLE_UPDATE_SERVICE, "FieldTrialB",

- "Group1", TEST_VALUE_B);

- AssociateGoogleVariationID(variations::GOOGLE_UPDATE_SERVICE, "FieldTrialC",

- "Default", TEST_VALUE_C);

- AssociateGoogleVariationID(variations::GOOGLE_UPDATE_SERVICE, "FieldTrialD",

- "Default", TEST_VALUE_D); // Not actually used.

+ AssociateGoogleVariationID(GOOGLE_UPDATE_SERVICE, "FieldTrialA", "Default",

+ TEST_VALUE_A);

+ AssociateGoogleVariationID(GOOGLE_UPDATE_SERVICE, "FieldTrialB", "Group1",

+ TEST_VALUE_B);

+ AssociateGoogleVariationID(GOOGLE_UPDATE_SERVICE, "FieldTrialC", "Default",

+ TEST_VALUE_C);

+ AssociateGoogleVariationID(GOOGLE_UPDATE_SERVICE, "FieldTrialD", "Default",

+ TEST_VALUE_D); // Not actually used.

for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {

// Parse the input groups.