dm/DMSKPTask.cpp - Issue 416333007: Fix crash in DM/SKPTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMSKPTask.cpp

Issue 416333007: Fix crash in DM/SKPTask (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMSKPTask.cpp

diff --git a/dm/DMSKPTask.cpp b/dm/DMSKPTask.cpp

index 295499b96168b9dcfdb723887cfdde27caaf9898..357d46e71915dd61576688d6b33d0aaad3e0c2ef 100644

--- a/dm/DMSKPTask.cpp

+++ b/dm/DMSKPTask.cpp

@@ -15,7 +15,7 @@ class SkrComparisonTask : public CpuTask {

public:

SkrComparisonTask(const Task& parent, const SkPicture* picture, SkBitmap reference)

: CpuTask(parent)

- , fPicture(picture)

+ , fPicture(SkRef(picture))

, fReference(reference)

, fName(UnderJoin(parent.name().c_str(), "skr")) {}

« no previous file with comments | « no previous file | no next file » | no next file with comments »