Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 416333004: Revert of [WebSocket] Send a close frame when the renderer process is gone. (Closed)

Created:
6 years, 5 months ago by Vladislav Kaznacheev
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Revert of [WebSocket] Send a close frame when the renderer process is gone. (https://codereview.chromium.org/390773002/) Reason for revert: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5350 Original issue's description: > [WebSocket] Send a close frame when the renderer process is gone. > > Renderer processes may die without clearing its |WebSocketBridge|s. > It is helpful to send a close frame with code = 1001 in such a case. > > BUG=392534 > R=ricea@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285557 TBR=ricea@chromium.org,jgraettinger@chromium.org,eroman@chromium.org,mmenke@chromium.org,yhirano@chromium.org NOTREECHECKS=true NOTRY=true BUG=392534 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -226 lines) Patch
M chrome/browser/net/websocket_browsertest.cc View 4 chunks +25 lines, -64 lines 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host_unittest.cc View 5 chunks +4 lines, -45 lines 0 comments Download
M content/browser/renderer_host/websocket_host.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/websocket_host.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M net/data/websocket/README View 2 chunks +0 lines, -15 lines 0 comments Download
M net/data/websocket/connect_check.html View 1 chunk +11 lines, -2 lines 0 comments Download
D net/data/websocket/count-connection_wsh.py View 1 chunk +0 lines, -26 lines 0 comments Download
D net/data/websocket/count_connection.html View 1 chunk +0 lines, -22 lines 0 comments Download
D net/data/websocket/counted_connection.html View 1 chunk +0 lines, -19 lines 0 comments Download
M net/data/websocket/split_packet_check.html View 1 chunk +10 lines, -2 lines 0 comments Download
M net/data/websocket/websocket_shared_worker.html View 2 chunks +9 lines, -2 lines 0 comments Download
M net/websockets/websocket_channel.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vladislav Kaznacheev
Created Revert of [WebSocket] Send a close frame when the renderer process is gone.
6 years, 5 months ago (2014-07-25 11:55:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/416333004/1
6 years, 5 months ago (2014-07-25 11:56:15 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 11:57:19 UTC) #3
Message was sent while issue was closed.
Change committed as 285564

Powered by Google App Engine
This is Rietveld 408576698