Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 416333003: Revert of skia/ext: Early out from analysis when we have more than 1 draw op. (Closed)

Created:
6 years, 5 months ago by lushnikov
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert of skia/ext: Early out from analysis when we have more than 1 draw op. (https://codereview.chromium.org/418093003/) Reason for revert: This change broke some tests in Blink Additionally, it renders DevTools shortcuts screen unusable (Open devTools -> F1 -> Shortcuts tab) http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=virtual%2Fandroid%2Ffullscreen%2Ffull-screen-fixed-pos-parent.html%2Cvirtual%2Fandroid%2Ffullscreen%2Ffull-screen-iframe-zIndex.html%2Cvirtual%2Fandroid%2Ffullscreen%2Ffull-screen-zIndex.html Original issue's description: > skia/ext: Early out from analysis when we have more than 1 draw op. > > This patch puts in a heuristic that earlies out from analysis when > we have more than one draw op. The intent here is that in most cases, > if we see more than one draw operation, then analysis is likely not > to be solid. > > It also removes HasText from analysis canvas, since the only > remaining use for this was a previous early out heuristic. > > BUG=397198 > R=enne > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285499 TBR=enne@chromium.org,senorblanco@google.com,junov@chromium.org,vmpstr@chromium.org NOTREECHECKS=true NOTRY=true BUG=397198 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -24 lines) Patch
M skia/ext/analysis_canvas.h View 2 chunks +2 lines, -1 line 0 comments Download
M skia/ext/analysis_canvas.cc View 19 chunks +12 lines, -23 lines 0 comments Download
M skia/ext/analysis_canvas_unittest.cc View 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
lushnikov
Created Revert of skia/ext: Early out from analysis when we have more than 1 draw ...
6 years, 5 months ago (2014-07-25 10:15:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/416333003/1
6 years, 5 months ago (2014-07-25 10:18:18 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 10:19:59 UTC) #3
Message was sent while issue was closed.
Change committed as 285554

Powered by Google App Engine
This is Rietveld 408576698