Source/modules/webaudio/MediaElementAudioSourceNode.cpp - Issue 416333002: Introduce AudioSourceProviderClientLockScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/MediaElementAudioSourceNode.cpp

Issue 416333002: Introduce AudioSourceProviderClientLockScope. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use AudioSourceProviderClientLockScope even if !ENABLE(WEB_AUDIO) Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/webaudio/MediaElementAudioSourceNode.cpp

diff --git a/Source/modules/webaudio/MediaElementAudioSourceNode.cpp b/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

index 0ccc0747bd06f73811a2c305c65f96774e6e3065..9bf19c8849481f963a4ad6945de4481bdf22bd78 100644

--- a/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

+++ b/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

@@ -147,14 +147,18 @@ void MediaElementAudioSourceNode::process(size_t numberOfFrames)

void MediaElementAudioSourceNode::lock()

{

- m_keepAliveWhileLocking = this;

+#if !ENABLE(OILPAN)

+ ref();

+#endif

m_processLock.lock();

}

void MediaElementAudioSourceNode::unlock()

{

m_processLock.unlock();

- m_keepAliveWhileLocking.clear();

+#if !ENABLE(OILPAN)

+ deref();

+#endif

}

void MediaElementAudioSourceNode::trace(Visitor* visitor)