Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 416313006: Update AssertMatchingEnums.cpp now that everything is in blink namespace (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 4 months ago
CC:
blink-reviews, lgombos, rwlbuis, yi
Project:
blink
Visibility:
Public.

Description

Update AssertMatchingEnums.cpp now that everything is in blink namespace Update AssertMatchingEnums.cpp now that everything is in blink namespace. This CL defines all assertions inside the blink namespace as well so that we don't have have to specify blink:: explicitly in the assertion macro. Public names cannot be identical to core blink ones anyway or they would clash now that they are in the same namespace. As a side effect, the same COMPILE_ASSERT_MATCHING_*() macros could now be reused for enumerations that are not in the blink namespace (e.g. in the WTF one) since the macros no longer specify blink:: explicitly. This CL also removes a few outdated references to WebKit / WebCore. R=abarth@chromium.org, eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M Source/web/AssertMatchingEnums.cpp View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 5 months ago (2014-07-25 18:46:42 UTC) #1
abarth-chromium
lgtm
6 years, 4 months ago (2014-07-29 16:30:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/416313006/1
6 years, 4 months ago (2014-07-29 16:30:35 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 16:33:48 UTC) #4
Message was sent while issue was closed.
Change committed as 179160

Powered by Google App Engine
This is Rietveld 408576698