Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 416273004: Remove WTF_USE_HARFBUZZ (Closed)

Created:
6 years, 5 months ago by eae
Modified:
6 years, 4 months ago
CC:
blink-reviews, Rik, danakj, krit, jamesr, jbroman, pdr., rwlbuis, Stephen Chennney
Project:
blink
Visibility:
Public.

Description

Remove WTF_USE_HARFBUZZ Remove the WTF_USE_HARFBUZZ define and the remaining use of it as it is it only used in files compiled on platforms where it is guaranteed to be true. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179185

Patch Set 1 #

Patch Set 2 : merge w/HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/config.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/fonts/skia/SimpleFontDataSkia.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
eae
Remove WTF_USE_HARFBUZZ Remove the WTF_USE_HARFBUZZ define and the remaining use of it as it is ...
6 years, 4 months ago (2014-07-29 21:29:11 UTC) #1
eae
6 years, 4 months ago (2014-07-29 21:29:17 UTC) #2
abarth-chromium
I moved your first comment to the description field.
6 years, 4 months ago (2014-07-29 21:53:48 UTC) #3
abarth-chromium
LGTM
6 years, 4 months ago (2014-07-29 21:53:58 UTC) #4
eae
On 2014/07/29 21:53:48, abarth wrote: > I moved your first comment to the description field. ...
6 years, 4 months ago (2014-07-29 22:03:10 UTC) #5
eae
The CQ bit was checked by eae@chromium.org
6 years, 4 months ago (2014-07-29 22:03:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/416273004/1
6 years, 4 months ago (2014-07-29 22:03:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 22:04:16 UTC) #8
commit-bot: I haz the power
Failed to apply patch for Source/config.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-07-29 22:04:17 UTC) #9
eae
The CQ bit was checked by eae@chromium.org
6 years, 4 months ago (2014-07-29 22:13:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/416273004/20001
6 years, 4 months ago (2014-07-29 22:14:38 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 23:43:35 UTC) #12
Message was sent while issue was closed.
Change committed as 179185

Powered by Google App Engine
This is Rietveld 408576698