extract_build failure should be fatal

extract_build failure should be fatal

This code has been here since this script was created back
in bug 154525, however these days the warning code is 88.
Maybe the warning code has always been 88, but its always been
OK for an extract_build step to be non-fatal.

I would be happy to test this if someone could explain
to me how this file is tested.

These days we expect extract_build to fail the build, if it doesn't
then we just go and run test with the wrong revision, etc.

BUG=397710, 154525
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285914

[eseidel, 2014-07-25 22:42:31]

ptal

[eseidel, 2014-07-25 22:43:43]

The only other code to use this warning_code= parameter is
check-webkit-licenses:

def CheckWebViewLicenses(_):
  bb_annotations.PrintNamedStep('check_licenses')
  RunCmd([SrcPath('android_webview', 'tools', 'webview_licenses.py'), 'scan'],
         warning_code=1)

[navabi, 2014-07-28 09:16:19]

lgtm

[navabi1, 2014-07-28 09:16:28]

lgtm

[eseidel, 2014-07-28 14:46:37]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2014-07-28 14:47:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eseidel@chromium.org/416243007/1

[commit-bot: I haz the power, 2014-07-28 15:59:18]

Change committed as 285914