Issue 416243003: Make RecursionData a stack-allocated variable in StyleInvalidator, since it is only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 416243003: Make RecursionData a stack-allocated variable in StyleInvalidator, since it is only (Closed)

Created:
6 years, 5 months ago by chrishtr

Modified:
6 years, 4 months ago

Reviewers:
esprehn

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make RecursionData a stack-allocated variable in StyleInvalidator, since it is only used during a single invalidation. These makes makes its intended object data lifetime clearer and avoids possible bugs. BUG=379908 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179050

Patch Set 1 #

Patch Set 2 : Reverted part of CL. #

Patch Set 3 : Fixed. #

Patch Set 4 : Fix. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -23 lines)			Patch
	M	Source/core/css/invalidation/StyleInvalidator.h	View	1 2 3	3 chunks	+4 lines, -6 lines	0 comments	Download
	M	Source/core/css/invalidation/StyleInvalidator.cpp	View	1 2	2 chunks	+18 lines, -17 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/416243003/60001

6 years, 4 months ago (2014-07-28 17:23:21 UTC) #5

Message was sent while issue was closed.

Change committed as 179050

Expand Messages | Collapse Messages