Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 41623002: Simulate field trial assignments with new variations seed. (Closed)

Created:
7 years, 2 months ago by Alexei Svitkine (slow)
Modified:
6 years, 11 months ago
Reviewers:
Mathieu, mathp, jwd, Jói
CC:
chromium-reviews
Visibility:
Public.

Description

Implement initial version of VariationSeedSimulator. This will be used by the VariationsService to simulate newly received variations seed, to evaluate whether there's sufficient new changes to badge the UI to suggest a restart (similar to what happens during auto updates). This is the initial version of this class and still has some missing pieces, left as TODOs. BUG=315807 TEST=Unit tests. TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243600

Patch Set 1 : #

Total comments: 8

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+534 lines, -0 lines) Patch
M components/components_tests.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/variations.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A components/variations/variations_seed_simulator.h View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A components/variations/variations_seed_simulator.cc View 1 2 1 chunk +187 lines, -0 lines 0 comments Download
A components/variations/variations_seed_simulator_unittest.cc View 1 chunk +287 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Alexei Svitkine (slow)
6 years, 12 months ago (2013-12-24 16:45:35 UTC) #1
Mathieu
One question below. Rest looks great! https://codereview.chromium.org/41623002/diff/1370002/components/variations/variations_seed_simulator.cc File components/variations/variations_seed_simulator.cc (right): https://codereview.chromium.org/41623002/diff/1370002/components/variations/variations_seed_simulator.cc#newcode46 components/variations/variations_seed_simulator.cc:46: if (!experiment.has_forcing_flag() && ...
6 years, 11 months ago (2013-12-30 15:21:37 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/41623002/diff/1370002/components/variations/variations_seed_simulator.cc File components/variations/variations_seed_simulator.cc (right): https://codereview.chromium.org/41623002/diff/1370002/components/variations/variations_seed_simulator.cc#newcode46 components/variations/variations_seed_simulator.cc:46: if (!experiment.has_forcing_flag() && On 2013/12/30 15:21:37, Mathieu Perreault wrote: ...
6 years, 11 months ago (2014-01-06 19:22:40 UTC) #3
mathp
lgtm https://codereview.chromium.org/41623002/diff/1370002/components/variations/variations_seed_simulator.cc File components/variations/variations_seed_simulator.cc (right): https://codereview.chromium.org/41623002/diff/1370002/components/variations/variations_seed_simulator.cc#newcode46 components/variations/variations_seed_simulator.cc:46: if (!experiment.has_forcing_flag() && On 2014/01/06 19:22:40, Alexei Svitkine ...
6 years, 11 months ago (2014-01-06 19:37:47 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/41623002/diff/1370002/components/variations/variations_seed_simulator.cc File components/variations/variations_seed_simulator.cc (right): https://codereview.chromium.org/41623002/diff/1370002/components/variations/variations_seed_simulator.cc#newcode46 components/variations/variations_seed_simulator.cc:46: if (!experiment.has_forcing_flag() && On 2014/01/06 19:37:47, mathp wrote: > ...
6 years, 11 months ago (2014-01-06 19:47:58 UTC) #5
jwd
LGTM with nits https://codereview.chromium.org/41623002/diff/1660001/components/variations/variations_seed_simulator.cc File components/variations/variations_seed_simulator.cc (right): https://codereview.chromium.org/41623002/diff/1660001/components/variations/variations_seed_simulator.cc#newcode131 components/variations/variations_seed_simulator.cc:131: } This seems to implicitly do ...
6 years, 11 months ago (2014-01-07 18:31:37 UTC) #6
Alexei Svitkine (slow)
https://codereview.chromium.org/41623002/diff/1660001/components/variations/variations_seed_simulator.cc File components/variations/variations_seed_simulator.cc (right): https://codereview.chromium.org/41623002/diff/1660001/components/variations/variations_seed_simulator.cc#newcode131 components/variations/variations_seed_simulator.cc:131: } On 2014/01/07 18:31:37, Jesse Doherty wrote: > This ...
6 years, 11 months ago (2014-01-08 15:17:35 UTC) #7
Alexei Svitkine (slow)
TBR=joi for components_tests.gyp
6 years, 11 months ago (2014-01-08 15:18:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/41623002/1900001
6 years, 11 months ago (2014-01-08 15:18:54 UTC) #9
Jói
components_tests.gyp LGTM.
6 years, 11 months ago (2014-01-08 16:59:51 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 18:21:03 UTC) #11
Message was sent while issue was closed.
Change committed as 243600

Powered by Google App Engine
This is Rietveld 408576698