Issue 416223003: Unify HasGDocFileExtension and IsHostedDocumentByExtentoin.

Issue 416223003: Unify HasGDocFileExtension and IsHostedDocumentByExtentoin. (Closed)

Created:
6 years, 5 months ago by kinaba

Modified:
6 years, 5 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, yoshiki+watch_chromium.org, nhiroki, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Unify HasGDocFileExtension and IsHostedDocumentByExtentoin. One more clean up before getting 397391 done. HasGDocFileExtension is a very thin wrapper of the latter function, and what all the callers need is the former interface. This CL merges those two functions into one to make it more easily searchable where in our code is relying on the extensions. BUG=397391 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285549

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -25 lines)			Patch
M	chrome/browser/chromeos/drive/file_system/copy_operation.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_util.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_util.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_util_unittest.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/file_manager/file_tasks.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/file_manager/open_with_browser.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/drive/drive_api_util.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/drive/drive_api_util.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/drive/drive_api_util_unittest.cc	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

hashimoto

lgtm https://codereview.chromium.org/416223003/diff/1/chrome/browser/drive/drive_api_util_unittest.cc File chrome/browser/drive/drive_api_util_unittest.cc (right): https://codereview.chromium.org/416223003/diff/1/chrome/browser/drive/drive_api_util_unittest.cc#newcode181 chrome/browser/drive/drive_api_util_unittest.cc:181: HasHostedDocumentExtension(base::FilePath::FromUTF8Unsafe("xx.glink"))); Seems this results in returning false?

6 years, 5 months ago (2014-07-25 06:19:59 UTC) #2

kinaba

https://codereview.chromium.org/416223003/diff/1/chrome/browser/drive/drive_api_util_unittest.cc File chrome/browser/drive/drive_api_util_unittest.cc (right): https://codereview.chromium.org/416223003/diff/1/chrome/browser/drive/drive_api_util_unittest.cc#newcode181 chrome/browser/drive/drive_api_util_unittest.cc:181: HasHostedDocumentExtension(base::FilePath::FromUTF8Unsafe("xx.glink"))); On 2014/07/25 06:19:59, hashimoto wrote: > Seems this ...

6 years, 5 months ago (2014-07-25 06:24:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/416223003/20001

6 years, 5 months ago (2014-07-25 06:36:37 UTC) #6

Message was sent while issue was closed.

Change committed as 285549

Expand Messages | Collapse Messages