Merge three PromiseEvent's into one.

Merge three PromiseEvent's into one.

This also adds missing instrumentation and removes resolver tracking.

BUG=v8:3093
LOG=N
R=aandrey@chromium.org, yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22846

[Alexandra Mikhaylova, 2014-07-31 15:34:02]

On 2014/07/31 15:33:14, Alexandra Mikhaylova wrote:

BTW, this is DevTools backend support for this:
https://codereview.chromium.org/433653003/.

[aandrey, 2014-08-01 07:46:18]

https://codereview.chromium.org/416213004/diff/20001/src/promise.js
File src/promise.js (right):

https://codereview.chromium.org/416213004/diff/20001/src/promise.js#newcode61
src/promise.js:61: var type = status === 0 ? "new" : "update";
remove this and the "type". if you really need it, you can do the logic in
PromiseEvent.prototype.type:

if (!this._status)
  return "new";
else if (this._promiseParent)
  return "chain";
else
  return "update";

https://codereview.chromium.org/416213004/diff/20001/test/mjsunit/es6/debug-p...
File test/mjsunit/es6/debug-promises-update-parent-event.js (right):

https://codereview.chromium.org/416213004/diff/20001/test/mjsunit/es6/debug-p...
test/mjsunit/es6/debug-promises-update-parent-event.js:19: if (event_data.type()
!= "chain") return;
just make 1 file to test all promise events

[Alexandra Mikhaylova, 2014-08-01 12:23:06]

https://codereview.chromium.org/416213004/diff/20001/src/promise.js
File src/promise.js (right):

https://codereview.chromium.org/416213004/diff/20001/src/promise.js#newcode61
src/promise.js:61: var type = status === 0 ? "new" : "update";
On 2014/08/01 07:46:18, aandrey wrote:
> remove this and the "type". if you really need it, you can do the logic in
> PromiseEvent.prototype.type:
> 
> if (!this._status)
>   return "new";
> else if (this._promiseParent)
>   return "chain";
> else
>   return "update";

Removed this as we can tell the type of event using status and parent on
backend.

https://codereview.chromium.org/416213004/diff/20001/test/mjsunit/es6/debug-p...
File test/mjsunit/es6/debug-promises-update-parent-event.js (right):

https://codereview.chromium.org/416213004/diff/20001/test/mjsunit/es6/debug-p...
test/mjsunit/es6/debug-promises-update-parent-event.js:19: if (event_data.type()
!= "chain") return;
On 2014/08/01 07:46:18, aandrey wrote:
> just make 1 file to test all promise events

Done.

[aandrey, 2014-08-01 13:22:21]

https://codereview.chromium.org/416213004/diff/60001/src/promise.js
File src/promise.js (right):

https://codereview.chromium.org/416213004/diff/60001/src/promise.js#newcode61
src/promise.js:61: %DebugPromiseEvent({ promise: promise,
nit: can it be a one liner now?

https://codereview.chromium.org/416213004/diff/60001/src/promise.js#newcode238
src/promise.js:238: %DebugPromiseEvent({ promise: deferred.promise,
ditto

https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-p...
File test/mjsunit/es6/debug-promise-events.js (right):

https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-p...
test/mjsunit/es6/debug-promise-events.js:44:
assertTrue(event_data.promise().isPromise());
code dup x3

https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-p...
test/mjsunit/es6/debug-promise-events.js:64: var p4 = p3.then();
there is still no tree of promises, isn't it? maybe test this also?

https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-p...
test/mjsunit/es6/debug-promise-events.js:66: function assertOrAbort(b, s) {
can we use same name from where it's copied, to ease code search

https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-p...
test/mjsunit/es6/debug-promise-events.js:78: function() {
extract this function to top level

[Alexandra Mikhaylova, 2014-08-01 13:44:53]

https://codereview.chromium.org/416213004/diff/60001/src/promise.js
File src/promise.js (right):

https://codereview.chromium.org/416213004/diff/60001/src/promise.js#newcode61
src/promise.js:61: %DebugPromiseEvent({ promise: promise,
On 2014/08/01 13:22:21, aandrey wrote:
> nit: can it be a one liner now?

Thanks! Fixed it.

https://codereview.chromium.org/416213004/diff/60001/src/promise.js#newcode238
src/promise.js:238: %DebugPromiseEvent({ promise: deferred.promise,
On 2014/08/01 13:22:21, aandrey wrote:
> ditto

Done.

https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-p...
File test/mjsunit/es6/debug-promise-events.js (right):

https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-p...
test/mjsunit/es6/debug-promise-events.js:44:
assertTrue(event_data.promise().isPromise());
On 2014/08/01 13:22:21, aandrey wrote:
> code dup x3

Done.

https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-p...
test/mjsunit/es6/debug-promise-events.js:64: var p4 = p3.then();
On 2014/08/01 13:22:21, aandrey wrote:
> there is still no tree of promises, isn't it? maybe test this also?

Done.

https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-p...
test/mjsunit/es6/debug-promise-events.js:66: function assertOrAbort(b, s) {
On 2014/08/01 13:22:21, aandrey wrote:
> can we use same name from where it's copied, to ease code search

Done.

https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-p...
test/mjsunit/es6/debug-promise-events.js:78: function() {
On 2014/08/01 13:22:21, aandrey wrote:
> extract this function to top level

Done.

[aandrey, 2014-08-01 14:55:54]

lgtm

[Yang, 2014-08-04 13:28:22]

On 2014/08/01 14:55:54, aandrey wrote:
> lgtm

A bit confused by this. Do we no longer care about the source of the event (aka
type)?

[Alexandra Mikhaylova, 2014-08-04 13:38:41]

On 2014/08/04 13:28:22, Yang wrote:
> On 2014/08/01 14:55:54, aandrey wrote:
> > lgtm
> 
> A bit confused by this. Do we no longer care about the source of the event
(aka
> type)?

We do, but we can tell the type according to property values (e.g. parentPromise
is not undefined => it's a promise chain, status is not undefined and != 0 =>
it's a promise update).

[aandrey, 2014-08-04 13:39:02]

On 2014/08/04 13:28:22, Yang wrote:
> On 2014/08/01 14:55:54, aandrey wrote:
> > lgtm
> 
> A bit confused by this. Do we no longer care about the source of the event
(aka
> type)?

we can calculate it from the data set that we receive

[Alexandra Mikhaylova, 2014-08-04 13:41:02]

On 2014/08/04 13:39:02, aandrey wrote:
> On 2014/08/04 13:28:22, Yang wrote:
> > On 2014/08/01 14:55:54, aandrey wrote:
> > > lgtm
> > 
> > A bit confused by this. Do we no longer care about the source of the event
> (aka
> > type)?
> 
> we can calculate it from the data set that we receive

I've updated the description of this issue as it was really confusing :)

[Yang, 2014-08-04 14:10:51]

LGTM. Will land as soon as the tree allows it.

[Yang, 2014-08-05 07:42:16]

Committed patchset #6 manually as r22846 (presubmit successful).