Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 416203002: Convert BeginReadData...() to use the new user pointer handling (see r285350). (Closed)

Created:
6 years, 5 months ago by viettrungluu
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Convert BeginReadData...() to use the new user pointer handling (see r285350). R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285601

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -66 lines) Patch
M mojo/system/core.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M mojo/system/core_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/data_pipe.h View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/system/data_pipe.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M mojo/system/data_pipe_consumer_dispatcher.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/system/data_pipe_consumer_dispatcher.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M mojo/system/dispatcher.h View 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/system/dispatcher.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/system/dispatcher_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M mojo/system/local_data_pipe.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/system/local_data_pipe.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/system/local_data_pipe_unittest.cc View 18 chunks +38 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 5 months ago (2014-07-24 21:29:43 UTC) #1
darin (slow to review)
LGTM
6 years, 5 months ago (2014-07-24 22:25:57 UTC) #2
viettrungluu
6 years, 5 months ago (2014-07-25 16:52:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r285601 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698