Issue 416183002: Fix gn generate for content_shell on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 416183002: Fix gn generate for content_shell on Windows (Closed)

Created:
6 years, 5 months ago by scottmg

Modified:
6 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix gn generate for content_shell on Windows deps in common section above. configs in executable section below (and shouldn't be in libs anyway). TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285379

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	content/shell/BUILD.gn	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/416183002/1

6 years, 5 months ago (2014-07-24 17:53:28 UTC) #3

Message was sent while issue was closed.

Change committed as 285379