Issue 416173003: Merge 176713 "Uptake http://trac.webkit.org/changeset/169848"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 416173003: Merge 176713 "Uptake http://trac.webkit.org/changeset/169848" (Closed)

Created:
6 years, 5 months ago by aarya

Modified:
6 years, 5 months ago

Reviewers:
kenneth.r.christiansen

CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2062/

Project:
blink

Visibility:
Public.

Merge 176713 "Uptake http://trac.webkit.org/changeset/169848" > Uptake http://trac.webkit.org/changeset/169848 > > Set |length| based on |buffer|, not |content|. Switch to using a for loop. > Switch to unsigned types since we are working with positive offsets > into a String. Make sure to never cross the length boundary. > > BUG=383703 > > Review URL: https://codereview.chromium.org/342163003 TBR=kenneth.r.christiansen@intel.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178858

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -4 lines)			Patch
M	Source/core/html/HTMLMetaElement-in.cpp	View	3 chunks	+8 lines, -5 lines	0 comments	Download
M	Source/web/tests/ViewportTest.cpp	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A +	Source/web/tests/data/viewport/viewport-138.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r178858.