Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: runtime/vm/object.cc

Issue 41613002: Don't inline functions if they have an active breakpoint. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/object_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 4492 matching lines...) Expand 10 before | Expand all | Expand 10 after
4503 set_kind_tag(AbstractBit::update(value, raw_ptr()->kind_tag_)); 4503 set_kind_tag(AbstractBit::update(value, raw_ptr()->kind_tag_));
4504 } 4504 }
4505 4505
4506 4506
4507 void Function::set_is_inlinable(bool value) const { 4507 void Function::set_is_inlinable(bool value) const {
4508 set_kind_tag(InlinableBit::update(value, raw_ptr()->kind_tag_)); 4508 set_kind_tag(InlinableBit::update(value, raw_ptr()->kind_tag_));
4509 } 4509 }
4510 4510
4511 4511
4512 bool Function::IsInlineable() const { 4512 bool Function::IsInlineable() const {
4513 return InlinableBit::decode(raw_ptr()->kind_tag_) && HasCode(); 4513 return (InlinableBit::decode(raw_ptr()->kind_tag_) &&
4514 HasCode() &&
4515 !Isolate::Current()->debugger()->HasBreakpoint(*this));
4514 } 4516 }
4515 4517
4516 4518
4517 void Function::set_is_visible(bool value) const { 4519 void Function::set_is_visible(bool value) const {
4518 set_kind_tag(VisibleBit::update(value, raw_ptr()->kind_tag_)); 4520 set_kind_tag(VisibleBit::update(value, raw_ptr()->kind_tag_));
4519 } 4521 }
4520 4522
4521 4523
4522 intptr_t Function::NumParameters() const { 4524 intptr_t Function::NumParameters() const {
4523 return num_fixed_parameters() + NumOptionalParameters(); 4525 return num_fixed_parameters() + NumOptionalParameters();
(...skipping 11062 matching lines...) Expand 10 before | Expand all | Expand 10 after
15586 return "_MirrorReference"; 15588 return "_MirrorReference";
15587 } 15589 }
15588 15590
15589 15591
15590 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const { 15592 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
15591 JSONObject jsobj(stream); 15593 JSONObject jsobj(stream);
15592 } 15594 }
15593 15595
15594 15596
15595 } // namespace dart 15597 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/object_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698