Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 416053002: Revert of Turn webspeech on/off when tab goes fore/background (Closed)

Created:
6 years, 5 months ago by johnme
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Turn webspeech on/off when tab goes fore/background (https://codereview.chromium.org/415433002/) Reason for revert: Tentatively reverting because [1] has been consistently crashing in 2 layout tests ever since this landed[2], and this is the more likely looking of the two CLs on the blamelist: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=%2Ftrunk%2Fsrc&range=285071%3A285072&mode=html http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=178788%3A178788&mode=html [1]: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29 [2]: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/16889 Original issue's description: > Turn webspeech off when tab goes background > > This change adds a toggle to turn webspeech off when tab goes background. > And further request to turn media capture devices on will be denied. > So Both WebRTC and webSpeech won't be able to initiate new requests when tab is in background. > > BUG=396054 > R=dalecurtis@chromium.org, jam@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285072 TBR=jam@chromium.org,juberti@chromium.org,xians@chromium.org,dalecurtis@google.com,dalecurtis@chromium.org,qinmin@chromium.org NOTREECHECKS=true NOTRY=true BUG=396054 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -29 lines) Patch
M chrome/browser/media/media_stream_devices_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 3 chunks +2 lines, -12 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/speech_recognition_dispatcher.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/speech_recognition_dispatcher.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
johnme
Created Revert of Turn webspeech on/off when tab goes fore/background
6 years, 5 months ago (2014-07-24 12:25:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/416053002/1
6 years, 5 months ago (2014-07-24 12:27:30 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 12:29:22 UTC) #3
Message was sent while issue was closed.
Change committed as 285208

Powered by Google App Engine
This is Rietveld 408576698