Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 416033002: For-of on null or undefined is an error (Closed)

Created:
6 years, 5 months ago by wingo
Modified:
6 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

For-of on null or undefined is an error The latest ES6 draft changed the behavior of for-of on null / undefined, which for once is a simplification. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -94 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/ast.h View 3 chunks +1 line, -9 lines 0 comments Download
M src/ast-value-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/parser.cc View 2 chunks +3 lines, -15 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/iteration-semantics.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wingo
6 years, 5 months ago (2014-07-24 11:04:00 UTC) #1
rossberg
lgtm
6 years, 5 months ago (2014-07-24 11:31:30 UTC) #2
Yang
6 years, 5 months ago (2014-07-24 13:40:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22602 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698