Gallery.app: Add touch operation to rotate images.

Gallery.app: Add touch operation to rotate images.

The CL:

 * Add rotation property to the Viewport class.
 * Update the rotation property by the TouchHandler class.
 * Reset Viewport properties when changing the image.

BUG=390695
TEST=on link
R=mtomasz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285460

[hirono, 2014-07-24 09:47:12]

PTAL the CL? Thank you!

[mtomasz, 2014-07-24 09:53:38]

On 2014/07/24 09:47:12, hirono wrote:
> PTAL the CL? Thank you!

typo: tocuh -> touch

[mtomasz, 2014-07-24 09:59:26]

https://codereview.chromium.org/416023002/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/image_editor/image_view.js (right):

https://codereview.chromium.org/416023002/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_view.js:556: var oldViewport =
this.viewport_.clone();
Do we need to clone? How about just creating a new instance?

var oldViewport = this.viewport_;
this.viewport_ = new Viewport()?

Would it work? WDYT?

https://codereview.chromium.org/416023002/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/slide_mode.js (right):

https://codereview.chromium.org/416023002/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1440: * @return {number} Radian of the
pinch twist angle.
Here we return radians, but in other places we work on degrees. Shall we choose
one unit? Maybe degrees?

https://codereview.chromium.org/416023002/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1447: var innerProduce = dx1 * dx2 +
dy1 * dy2;  // |v1| * |v2| * cos(t) = x / r
nit: Did you mean inner product?

[hirono, 2014-07-24 10:13:08]

Thanks!

https://codereview.chromium.org/416023002/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/image_editor/image_view.js (right):

https://codereview.chromium.org/416023002/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_view.js:556: var oldViewport =
this.viewport_.clone();
On 2014/07/24 09:59:25, mtomasz wrote:
> Do we need to clone? How about just creating a new instance?
> 
> var oldViewport = this.viewport_;
> this.viewport_ = new Viewport()?
> 
> Would it work? WDYT?

It would not work because the viewport is shared by a few classes.

https://codereview.chromium.org/416023002/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/slide_mode.js (right):

https://codereview.chromium.org/416023002/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1440: * @return {number} Radian of the
pinch twist angle.
On 2014/07/24 09:59:25, mtomasz wrote:
> Here we return radians, but in other places we work on degrees. Shall we
choose
> one unit? Maybe degrees?

Let me choose degrees that works fine with CSS transformation.

https://codereview.chromium.org/416023002/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1447: var innerProduce = dx1 * dx2 +
dy1 * dy2;  // |v1| * |v2| * cos(t) = x / r
On 2014/07/24 09:59:25, mtomasz wrote:
> nit: Did you mean inner product?

Oops, yes.

[mtomasz, 2014-07-24 11:22:21]

lgtm with an optional nit

https://codereview.chromium.org/416023002/diff/60001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/slide_mode.js (right):

https://codereview.chromium.org/416023002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1540: if (angle > 25)
nit: constant?

[hirono, 2014-07-25 01:03:41]

Thanks!

https://codereview.chromium.org/416023002/diff/60001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/slide_mode.js (right):

https://codereview.chromium.org/416023002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/slide_mode.js:1540: if (angle > 25)
On 2014/07/24 11:22:21, mtomasz wrote:
> nit: constant?

Done.

[hirono, 2014-07-25 01:03:44]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-07-25 01:07:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/416023002/80001

[hirono, 2014-07-25 02:38:16]

Committed patchset #5 manually as r285460 (presubmit successful).