Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 416013002: Remove WebSettings::setDisallowFullscreenForNonMediaElements(bool) (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Project:
blink
Visibility:
Public.

Description

Remove WebSettings::setDisallowFullscreenForNonMediaElements(bool) It is never called from Chromium. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M Source/web/FullscreenController.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
PTAL
6 years, 5 months ago (2014-07-24 09:13:27 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-24 09:25:40 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-24 09:28:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/416013002/1
6 years, 5 months ago (2014-07-24 09:29:22 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-24 09:56:19 UTC) #5
commit-bot: I haz the power
Change committed as 178831
6 years, 5 months ago (2014-07-24 10:40:43 UTC) #6
Ignacio Solla
On 2014/07/24 10:40:43, I haz the power (commit-bot) wrote: > Change committed as 178831 Could ...
6 years, 4 months ago (2014-07-28 16:35:36 UTC) #7
Ignacio Solla
6 years, 4 months ago (2014-07-28 16:43:54 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/422923002/ by igsolla@chromium.org.

The reason for reverting is: We need this for the Android WebView.

Powered by Google App Engine
This is Rietveld 408576698