Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 415973005: Move omnibox icons to components (2/2) (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, James Su, oshima+watch_chromium.org, extensions-reviews_chromium.org, Jun Mukai
Project:
chromium
Visibility:
Public.

Description

Move omnibox icons to components (2/2) To stop depending on resources under chrome/ from AutocompleteMatch. Move 3 icons from chrome/ to components/. BUG=388510 TEST=build R=blundell@chromium.org, oshima@chromium.org, pkasting@chromium.org TBR=sky@chromium.org for GN fix Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286167

Patch Set 1 #

Patch Set 2 : Autocomplete -> Omnibox #

Patch Set 3 : rebase #

Patch Set 4 : Fix GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
D chrome/app/theme/default_100_percent/common/omnibox_extension_app.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/omnibox_http.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/omnibox_search.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_extension_app.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_http.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_search.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/resources/default_100_percent/common/omnibox/omnibox_extension_app.png View 1 Binary file 0 comments Download
A + components/resources/default_100_percent/common/omnibox/omnibox_http.png View 1 Binary file 0 comments Download
A + components/resources/default_100_percent/common/omnibox/omnibox_search.png View 1 Binary file 0 comments Download
A + components/resources/default_200_percent/common/omnibox/omnibox_extension_app.png View 1 Binary file 0 comments Download
A + components/resources/default_200_percent/common/omnibox/omnibox_http.png View 1 Binary file 0 comments Download
A + components/resources/default_200_percent/common/omnibox/omnibox_search.png View 1 Binary file 0 comments Download
M components/resources/omnibox_scaled_resources.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hashimoto
blundell@: Please review as an owner of components. pkasting@: Please review as an owner of ...
6 years, 5 months ago (2014-07-24 10:16:54 UTC) #1
Peter Kasting
As noted on https://codereview.chromium.org/415073003/ , it would be nice not to use the word "autocomplete" ...
6 years, 5 months ago (2014-07-24 18:38:33 UTC) #2
hashimoto
Renamed the directories named "autocomplete" to "omnibox".
6 years, 5 months ago (2014-07-25 05:27:24 UTC) #3
hashimoto
Colin, could you take a look at this change as an owner of components?
6 years, 5 months ago (2014-07-25 05:27:55 UTC) #4
blundell
LGTM pending same question re: autocomplete and omnibox code merge that I've stated everywhere else
6 years, 5 months ago (2014-07-25 07:44:09 UTC) #5
hashimoto
oshima@, could you take a look at this change as an owner of chrome/app/theme?
6 years, 4 months ago (2014-07-28 08:03:53 UTC) #6
oshima
c/a/theme lgtm
6 years, 4 months ago (2014-07-28 17:15:20 UTC) #7
hashimoto
Committed patchset #3 manually as r286120 (presubmit successful).
6 years, 4 months ago (2014-07-29 08:10:33 UTC) #8
hashimoto
Added a line to chrome/browser/BUILD.gn to fix GN builds. Verified with trybots in https://codereview.chromium.org/423083003/.
6 years, 4 months ago (2014-07-29 10:44:53 UTC) #9
hashimoto
6 years, 4 months ago (2014-07-29 10:49:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 manually as r286167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698