Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 415973004: Extend the interceptor setter ASSERT to support the JSGlobalProxy case. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Extend the interceptor setter ASSERT to support the JSGlobalProxy case. BUG=v8:3463 LOG=n R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/stub-cache.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-24 09:30:28 UTC) #1
dcarney
lgtm
6 years, 5 months ago (2014-07-24 09:31:02 UTC) #2
Toon Verwaest
Committed patchset #1 manually as r22589 (presubmit successful).
6 years, 5 months ago (2014-07-24 09:31:50 UTC) #3
indutny
6 years, 5 months ago (2014-07-24 12:38:44 UTC) #4
Message was sent while issue was closed.
On 2014/07/24 09:31:50, Toon Verwaest wrote:
> Committed patchset #1 manually as r22589 (presubmit successful).

Thank you!

Powered by Google App Engine
This is Rietveld 408576698