Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 415963002: ServiceWorker: Implement ServiceWorkerRegistration [2/3] (Closed)

Created:
6 years, 5 months ago by nhiroki
Modified:
6 years, 5 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Implement ServiceWorkerRegistration [2/3] This implements WebServiceWorkerRegistration based on the latest spec and resolves a register promise with it instead of a ServiceWorker object. Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-registration-obj [1] Blink: https://codereview.chromium.org/413123002/ [2] Chromium: This patch. [3] Blink: Remove the macro and fix a bunch of layout tests. BUG=396400 TEST=compile (tests will be added by subsequent patches) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285599

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -14 lines) Patch
M content/child/service_worker/service_worker_dispatcher.h View 3 chunks +6 lines, -3 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 5 chunks +12 lines, -7 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A content/child/service_worker/web_service_worker_registration_impl.h View 1 chunk +32 lines, -0 lines 0 comments Download
A content/child/service_worker/web_service_worker_registration_impl.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M content/content_child.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nhiroki
Ptal.
6 years, 5 months ago (2014-07-24 07:34:14 UTC) #1
michaeln
i wonder if we should do the refactoring described in crbug/384119 in support of this ...
6 years, 5 months ago (2014-07-25 00:47:29 UTC) #2
falken
this change lgtm The IPC refactoring is desirable but I'm not sure the extent to ...
6 years, 5 months ago (2014-07-25 06:19:21 UTC) #3
nhiroki
On 2014/07/25 00:47:29, michaeln wrote: > i wonder if we should do the refactoring described ...
6 years, 5 months ago (2014-07-25 07:20:07 UTC) #4
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 5 months ago (2014-07-25 14:33:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/415963002/40001
6 years, 5 months ago (2014-07-25 14:34:40 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 16:48:30 UTC) #7
Message was sent while issue was closed.
Change committed as 285599

Powered by Google App Engine
This is Rietveld 408576698