Introduce NonJSProxyHolder returning Handle<JSObject> and return Handle<JSReceiver> for GetHolder

src/lookup.h

Index: src/lookup.h
diff --git a/src/lookup.h b/src/lookup.h
index c96a1e66e7b981aa04fec81797008e0c65ee075a..1881cda373159a94c507b74f4be47499c7a5ad5c 100644
--- a/src/lookup.h
+++ b/src/lookup.h
@@ -93,7 +93,11 @@ class LookupIterator V8_FINAL BASE_EMBEDDED {
     return Handle<Object>::cast(maybe_receiver_.ToHandleChecked());
   }
   Handle<Map> holder_map() const { return holder_map_; }
-  Handle<JSObject> GetHolder() const {
+  Handle<JSReceiver> GetHolder() const {
+    ASSERT(IsFound());
+    return maybe_holder_.ToHandleChecked();
+  }
+  Handle<JSObject> GetNonJSProxyHolder() const {

[rossberg, 2014/07/24 11:18:32]

You should call it GetJSObjectHolder.

But I'm not sure I like such random downcast accessors all that much. How about
changing GetHolder to

template<class T>
Handle<T> GetHolder() const {
  ASSERT(IsFound());
  return Handle<T>::cast(maybe_holder_.ToHandleChecked());
}

     ASSERT(IsFound() && state_ != JSPROXY);
     return Handle<JSObject>::cast(maybe_holder_.ToHandleChecked());
   }