Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 415863002: Remove focusFirstElement as it's never called in current Chrome source (Closed)

Created:
6 years, 5 months ago by Vitaly Pavlenko
Modified:
6 years, 4 months ago
Reviewers:
Kyle Horimoto, Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@typechecking_about
Project:
chromium
Visibility:
Public.

Description

Remove focusFirstElement as it's never called in current Chrome source BUG=393873 R=dbeam@chromium.org,khorimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ui/webui/resources/js/cr/ui/focus_manager.js View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vitaly Pavlenko
6 years, 5 months ago (2014-07-25 22:36:20 UTC) #1
Dan Beam
lgtm
6 years, 5 months ago (2014-07-25 22:37:09 UTC) #2
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 5 months ago (2014-07-26 02:11:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/415863002/1
6 years, 5 months ago (2014-07-26 05:00:37 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-26 19:44:17 UTC) #5
Message was sent while issue was closed.
Change committed as 285791

Powered by Google App Engine
This is Rietveld 408576698