sdk/lib/html/html_common/conversions.dart - Issue 41583005: ImageData.data is a Uint8ClampedList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/html_common/conversions.dart

Issue 41583005: ImageData.data is a Uint8ClampedList (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/html_common/conversions.dart

diff --git a/sdk/lib/html/html_common/conversions.dart b/sdk/lib/html/html_common/conversions.dart

index 35d6c688dc63e79e9216fb2c96ca90e19b7c4c54..3bd2973a9e1c50d9872f665897e96ec6706578f2 100644

--- a/sdk/lib/html/html_common/conversions.dart

+++ b/sdk/lib/html/html_common/conversions.dart

@@ -351,11 +351,11 @@ ImageData convertNativeToDart_ImageData(nativeImageData) {

if (nativeImageData is ImageData) return nativeImageData;

- // On Firefox the above test fails because imagedata is a plain object.

- // So we create a _TypedImageData.

+ // On Firefox the above test fails because [nativeImageData] is a plain

+ // object. So we create a _TypedImageData.

return new _TypedImageData(

- JS('var', '#.data', nativeImageData),

+ JS('Uint8ClampedList', '#.data', nativeImageData),

JS('var', '#.height', nativeImageData),

JS('var', '#.width', nativeImageData));

}

« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | tools/dom/scripts/dartmetadata.py » ('j') | no next file with comments »