Issue 415823002: Drop slower Node::hasTagName(QualifiedName) overload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 415823002: Drop slower Node::hasTagName(QualifiedName) overload (Closed)

Created:
6 years, 5 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
abarth-chromium, eseidel

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, groby+blinkspell_chromium.org, rwlbuis, rune+blink, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Drop slower Node::hasTagName(QualifiedName) overload Drop slower Node::hasTagName(QualifiedName) overload. It is only used by SiblingTraversalStrategies at this point. The objective is to encourage future callers to use the faster alternatives: - HTMLElement::hasTagName(HTMLQualifiedName) / SVGElement::hasTagName(SVGQualifiedName) - Node::hasTagName(HTMLQualifiedName) / Node::hasTagName(SVGQualifiedName) - Element::hasTagName(QualifiedName) R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179165

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -10 lines)			Patch
M	Source/core/css/SiblingTraversalStrategies.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/Element.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/dom/Node.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Inactive

I took care of the changes to editing/ separately and rebased this patch. The diff ...

6 years, 5 months ago (2014-07-25 00:38:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/415823002/20001

6 years, 4 months ago (2014-07-29 17:51:51 UTC) #5

Message was sent while issue was closed.

Change committed as 179165

Expand Messages | Collapse Messages