Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 415823002: Drop slower Node::hasTagName(QualifiedName) overload (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 4 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, groby+blinkspell_chromium.org, rwlbuis, rune+blink, sof
Project:
blink
Visibility:
Public.

Description

Drop slower Node::hasTagName(QualifiedName) overload Drop slower Node::hasTagName(QualifiedName) overload. It is only used by SiblingTraversalStrategies at this point. The objective is to encourage future callers to use the faster alternatives: - HTMLElement::hasTagName(HTMLQualifiedName) / SVGElement::hasTagName(SVGQualifiedName) - Node::hasTagName(HTMLQualifiedName) / Node::hasTagName(SVGQualifiedName) - Element::hasTagName(QualifiedName) R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179165

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M Source/core/css/SiblingTraversalStrategies.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 5 months ago (2014-07-23 22:40:14 UTC) #1
Inactive
I took care of the changes to editing/ separately and rebased this patch. The diff ...
6 years, 5 months ago (2014-07-25 00:38:09 UTC) #2
Inactive
ping review?
6 years, 4 months ago (2014-07-29 13:20:10 UTC) #3
abarth-chromium
lgtm
6 years, 4 months ago (2014-07-29 17:51:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/415823002/20001
6 years, 4 months ago (2014-07-29 17:51:51 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 17:55:12 UTC) #6
Message was sent while issue was closed.
Change committed as 179165

Powered by Google App Engine
This is Rietveld 408576698