chrome/browser/extensions/extension_action_manager.h - Issue 415813003: Improve extension icon prediction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_manager.h

Issue 415813003: Improve extension icon prediction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pointer stuff Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_action_manager.h

diff --git a/chrome/browser/extensions/extension_action_manager.h b/chrome/browser/extensions/extension_action_manager.h

index b78e8a2bd8600e9674b291cd08ac3f9fa19ad13e..53d43190d67a0606feb103fbc6e5e4782328fca3 100644

--- a/chrome/browser/extensions/extension_action_manager.h

+++ b/chrome/browser/extensions/extension_action_manager.h

@@ -41,6 +41,11 @@ class ExtensionActionManager : public KeyedService,

ExtensionAction* GetSystemIndicator(

const extensions::Extension& extension) const;

+ // Gets the best fit ExtensionAction for the given |extension|.

+ // Excludes system indicators.

not at google - send to devlin 2014/08/01 18:43:37 eh, I'd remove that second sentence, implementatio

gpdavis 2014/08/01 20:23:10 Fair enough.

+ scoped_ptr<ExtensionAction> GetBestFitAction(

+ const extensions::Extension& extension) const;

private:

// Implement ExtensionRegistryObserver.

virtual void OnExtensionUnloaded(content::BrowserContext* browser_context,