Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1782)

Issue 415803005: Load apps on separate threads in service_manager_unittests (Closed)

Created:
6 years, 5 months ago by jamesr
Modified:
6 years, 5 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Load apps on separate threads in service_manager_unittests This loads up and destroys applications on their own thread (using BackgroundServiceLoader) so we can test the full in-process application lifecycle. BUG=396300 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285410

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -108 lines) Patch
M mojo/service_manager/service_manager_unittest.cc View 1 13 chunks +159 lines, -108 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jamesr
This depends on https://codereview.chromium.org/380413003/ and re-enabled some of the tests that disabled.
6 years, 5 months ago (2014-07-23 22:28:20 UTC) #1
DaveMoore
lgtm
6 years, 5 months ago (2014-07-24 16:34:54 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 5 months ago (2014-07-24 18:14:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/415803005/20001
6 years, 5 months ago (2014-07-24 18:17:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 21:28:41 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 22:01:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2100)
6 years, 5 months ago (2014-07-24 22:01:19 UTC) #7
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 5 months ago (2014-07-24 22:01:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/415803005/20001
6 years, 5 months ago (2014-07-24 22:04:56 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 22:37:33 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 23:44:34 UTC) #11
Message was sent while issue was closed.
Change committed as 285410

Powered by Google App Engine
This is Rietveld 408576698