Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 415773008: Remove dead code backing WheelEvent.webkitDirectionInvertedFromDevice (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Project:
blink
Visibility:
Public.

Description

Remove dead code backing WheelEvent.webkitDirectionInvertedFromDevice It always returns false. Make that explicit. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M Source/core/events/WheelEvent.h View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/events/WheelEvent.cpp View 5 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/PlatformWheelEvent.h View 4 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 5 months ago (2014-07-24 14:33:54 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-24 14:38:55 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-24 14:40:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/415773008/1
6 years, 5 months ago (2014-07-24 14:40:44 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 15:39:18 UTC) #5
Message was sent while issue was closed.
Change committed as 178846

Powered by Google App Engine
This is Rietveld 408576698