Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 415753002: Deprecate the webkit-prefixed standard IndexedDB entry points (Closed)

Created:
6 years, 5 months ago by jsbell
Modified:
6 years, 4 months ago
CC:
blink-reviews, caseq+blink_chromium.org, jsbell+idb_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, alecflett, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, cmumford, devtools-reviews_chromium.org, dgrogan, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Deprecate the webkit-prefixed standard IndexedDB entry points We've shipped unprefixed (e.g. indexedDB, IDBKeyRange, etc) for almost two years. Time to at least try to wean the web off of them. Intent to Deprecate: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6TD2jjqAJs0 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179058

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add replacedBy() helper #

Patch Set 3 : More rebaselines for console warnings in property enumerating tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -108 lines) Patch
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/everything-to-string-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/js/global-constructors-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/indexeddb/database-data.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/indexeddb/database-data-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/http/tests/inspector/indexeddb/database-names-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/inspector/indexeddb/database-structure-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/inspector/indexeddb/resources-panel-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/security/cross-origin-indexeddb-allowed-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/security/cross-origin-worker-indexeddb-allowed-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/security/isolatedWorld/all-window-properties-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/isolatedWorld/all-window-prototypes-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/no-indexeddb-from-sandbox.html View 1 chunk +4 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/security/no-indexeddb-from-sandbox-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/resources/cross-origin-iframe-for-indexeddb.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/resources/worker-for-indexeddb.js View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/storage/indexeddb/factory-deletedatabase-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/index-basics-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/index-basics-workers-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/index-cursor-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/objectstore-clear-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/objectstore-removeobjectstore-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/resources/factory-deletedatabase.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/resources/index-basics.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/resources/index-cursor.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/resources/objectstore-clear.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/resources/objectstore-removeobjectstore.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/resources/shared.js View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/storage/indexeddb/unprefix-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/unprefix-workers-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-dedicated-worker-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-dedicated-worker-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ManualTests/indexeddb-persists.html View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 4 chunks +37 lines, -4 lines 0 comments Download
M Source/devtools/front_end/resources/IndexedDBViews.js View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/indexeddb/WindowIndexedDatabase.idl View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jsbell
Still waiting on the requisite approval on the "Intent", so not landing this yet. I ...
6 years, 5 months ago (2014-07-23 20:06:10 UTC) #1
jsbell
https://codereview.chromium.org/415753002/diff/1/LayoutTests/storage/indexeddb/resources/shared.js File LayoutTests/storage/indexeddb/resources/shared.js (left): https://codereview.chromium.org/415753002/diff/1/LayoutTests/storage/indexeddb/resources/shared.js#oldcode27 LayoutTests/storage/indexeddb/resources/shared.js:27: function removeVendorPrefixes() Since this is used by nearly all ...
6 years, 5 months ago (2014-07-23 20:12:52 UTC) #2
eseidel
lgtm https://codereview.chromium.org/415753002/diff/1/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js File LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js (left): https://codereview.chromium.org/415753002/diff/1/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js#oldcode103 LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js:103: var indexedDB = window.indexeddb || window.webkitIndexedDB; I might ...
6 years, 5 months ago (2014-07-23 20:18:31 UTC) #3
jsbell
https://codereview.chromium.org/415753002/diff/1/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/415753002/diff/1/Source/core/frame/UseCounter.cpp#newcode701 Source/core/frame/UseCounter.cpp:701: return "'webkitIndexedDB' is deprecated. Please use the standard 'indexedDB' ...
6 years, 5 months ago (2014-07-23 21:12:42 UTC) #4
cmumford
lgtm. I'm guessing that these four files will be modified once these are fully removed: ...
6 years, 5 months ago (2014-07-23 23:51:59 UTC) #5
jsbell
On 2014/07/23 23:51:59, cmumford wrote: > lgtm. I'm guessing that these four files will be ...
6 years, 5 months ago (2014-07-23 23:55:02 UTC) #6
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 4 months ago (2014-07-28 21:22:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/415753002/40001
6 years, 4 months ago (2014-07-28 21:23:16 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 21:28:06 UTC) #9
Message was sent while issue was closed.
Change committed as 179058

Powered by Google App Engine
This is Rietveld 408576698