Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Issue 415713002: Added support for relative paths for the .gclient cache_dir field. (Closed)

Created:
6 years, 5 months ago by David Yen
Modified:
6 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Added support for relative paths for the .gclient cache_dir field. R=iannucci@chromium.org BUG=None TEST=gclient sync with a relative and absolute "cache_dir" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=288146

Patch Set 1 #

Patch Set 2 : Have relative path be relative to root directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M gclient.py View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
David Yen
6 years, 5 months ago (2014-07-23 17:32:13 UTC) #1
David Yen
I have a separate chromium and clankium checkout, so this is the best feature since ...
6 years, 5 months ago (2014-07-23 17:41:09 UTC) #2
David Yen
ping
6 years, 4 months ago (2014-08-07 20:59:50 UTC) #3
iannucci
Lgtm, sorry about the lag. Please let the trooper know that you plan to land ...
6 years, 4 months ago (2014-08-07 21:10:36 UTC) #4
David Yen
The CQ bit was checked by dyen@chromium.org
6 years, 4 months ago (2014-08-07 21:38:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyen@chromium.org/415713002/20001
6 years, 4 months ago (2014-08-07 21:39:15 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 21:41:54 UTC) #7
Message was sent while issue was closed.
Change committed as 288146

Powered by Google App Engine
This is Rietveld 408576698